Merge remote-tracking branch 'origin/hivemind_optimizer_thirdtimesthecharm' into hivemind_optimizer_thirdtimesthecharm

hivemind/optim/experimental/progress_tracker.py

@@ -219,7 +219,7 @@ class ProgressTracker(threading.Thread):
                 )
         finally:
             logger.log(self.status_loglevel, f"No longer reporting progress for {self.prefix}.")
-            if store_task is not None and not store_task.done():
+            if store_task is not None:
                 store_task.cancel()
 
     async def _progress_fetcher(self):

tests/test_optimizer.py

@@ -278,7 +278,6 @@ def test_progress_tracker():
     assert not tracker.is_alive()
 
     mean_step_time = sum(step_time_deltas) / len(step_time_deltas)
-    print(step_time_deltas, mean_step_time)
     for i in (0, 1, 5):  # Without the 4th worker (the fastest one)
         assert 1.05 * mean_step_time < step_time_deltas[i] < 2.0 * mean_step_time
     for i in (2, 3, 4):  # With the 4th worker