Преглед на файлове

Fix test_allreduce_grid(), skip test_overcrowded()

Aleksandr Borzunov преди 4 години
родител
ревизия
356cff0acc
променени са 1 файла, в които са добавени 8 реда и са изтрити 1 реда
  1. 8 1
      tests/test_averaging.py

+ 8 - 1
tests/test_averaging.py

@@ -1,5 +1,5 @@
 import random
-from typing import List
+import time
 
 import numpy as np
 import pytest
@@ -255,6 +255,10 @@ def test_allreduce_grid():
     prev_means, prev_stds = means0, stds0
 
     for i in range(5):
+        time.sleep(0.2)
+        # FIXME (@justheuristic): An averager does not have time to update the key in GroupKeyManager
+        # if .step() is called without any delays
+
         step_futures = [averager.step(wait=False) for averager in averagers]
         groups = [future.result() for future in step_futures]
         [means], [stds] = compute_mean_std(averagers)
@@ -378,6 +382,9 @@ def test_too_few_peers():
         averager.shutdown()
 
 
+# TODO(@justheuristic): Finish the elasticity_0.0.1 branch and make this test work
+@pytest.mark.skip(reason="The current implementation of elasticity (multi-stage averaging for the case when "
+                         "num_peers > ~3 * target_group_size) is incorrect. Contact @justheuristic for more info")
 @pytest.mark.forked
 def test_overcrowded(num_peers=16):
     dht_instances = launch_dht_instances(num_peers)